I’m in the middle of a C++ project where I’m using cylinders to make a clock, I successfully made a circle using gl_line_strip but I need cylinders, I figure I could just add another dimension to add a height to it but I’m now thinking that isn’t the way.

Circle:

void drawCircle(float Radius, int numPoints)
{
float PI = 3.14159;
glBegin( GL_LINE_STRIP );
for( int i=0; i<numPoints; i++ )
{
float Angle = i * (2.0*PI/numPoints);
float X = cos( Angle )*Radius;
float Y = sin( Angle )*Radius;
float Z = (0.0f, 0.0f, 30.1f);
glVertex3f( X, Y, Z);
}
glEnd();
}

Is there a way I can modify this to make it a cylinder, or would I need to go in a completely different direction?

I 'd be interested to know myself if there is a more efficient way but the least you can do is this:

I assume that x,y,z in your code are homogeneous coords. Then add a 4th one, w, let that be your “extra” one and let z be the 3rd coordinate in space.

then
x = rcos(angle)
y = rsin(angle)
z = cylinderheight/2
w=(0.0f,0.0f,0.0f,1.0f)

running a loop similar to what you already have
gives you a circle in 3d space that is situated at z=cylinderheight/2, you can instead use
x = rcos(angle)
y = cylinderheight/2
z = rsin(angle)
w=(0.0f,0.0f,0.0f,1.0f)

if you wanted your cylinder to sit “upright” instead.

Then run a similar loop again replacing cylinderheight/2 with -cylinderheight/2. That will give you a second circle, so now you have the “top” and “bottom” of the cylinder. So now you can use a line_strip for each of the circles and then connect corresponding points between the circles with line. That gives a convincing representation of a cylinder, but like I said, I 'm not sure if there’s a more efficient way. Intuition dictates that it should be possible to do it with just one loop - the one you currently have - , just by “projecting” the circle, just haven’t worked out details yet. And there may yet be some more efficient technique I don’t know of.

(and of course that’s just an example, you can adjust the coords to have the cylinder top and bottom wherever you wish)

[QUOTE=Kophay;1240994]I 'd be interested to know myself if there is a more efficient way but the least you can do is this:

I assume that x,y,z in your code are homogeneous coords. Then add a 4th one, w, let that be your “extra” one and let z be the 3rd coordinate in space.

then
x = rcos(angle)
y = rsin(angle)
z = cylinderheight/2
w=(0.0f,0.0f,0.0f,1.0f)

running a loop similar to what you already have
gives you a circle in 3d space that is situated at z=cylinderheight/2, you can instead use
x = rcos(angle)
y = cylinderheight/2
z = rsin(angle)
w=(0.0f,0.0f,0.0f,1.0f)

if you wanted your cylinder to sit “upright” instead.

Then run a similar loop again replacing cylinderheight/2 with -cylinderheight/2. That will give you a second circle, so now you have the “top” and “bottom” of the cylinder. So now you can use a line_strip for each of the circles and then connect corresponding points between the circles with line. That gives a convincing representation of a cylinder, but like I said, I 'm not sure if there’s a more efficient way. Intuition dictates that it should be possible to do it with just one loop - the one you currently have - , just by “projecting” the circle, just haven’t worked out details yet. And there may yet be some more efficient technique I don’t know of.

(and of course that’s just an example, you can adjust the coords to have the cylinder top and bottom wherever you wish)[/QUOTE]

Works, thank you. But I’m having trouble drawing the second circle. So I edited my for loop to have the first circle in it, but I can’t seem to get the second to draw.

Since the the 3rd loop just recreates points of the circles it should be possible to use the so called indexed drawing to reuse them. Varying the j step you can get as many or as few points on the circles as you like and use other primitive types to draw between them. And use your shaders to prettify them.

Here’s a couple of pics of what the above looks like

So after some tweaking I managed to draw the cylinder without glDrawElements, still using my for loops. So my for loops are all in a function, then called and I specify the radius, height and number of sides.

Is there a way I can call this function multiple times to draw the cylinder, but multiple places?
I tried a for loop which calls then glTranslates, but it didn’t seem to work.

then post your draw loop and let’s see. More than likely you are not preserving the current state of the modelview matrix between draw calls.
When you post, statements like

but it didn’t seem to work.
are not helpful and won’t get you any answers. Please state what did not work and what you observered.